-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: not found page when select draft policy #43153
Conversation
@rojiphil We have 2 blockers #43073 and another relating to
App/src/pages/home/report/withReportOrNotFound.tsx Lines 60 to 70 in f15ba48
App/src/libs/DistanceRequestUtils.ts Line 93 in f15ba48
if (!distanceRate) {
return null;
} |
Bump @rojiphil |
@rojiphil Let's keep this moving since we're no longer holding. |
@@ -82,6 +83,7 @@ function BaseListItem<TItem extends ListItem>({ | |||
onSelectRow(item); | |||
}} | |||
disabled={isDisabled && !item.isSelected} | |||
interactive={isInteractive} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tienifr for the PR. This tests well but I have just one comment here.
Why do we pass isInteractive
all along the way from BaseSelectionList--> ListItem --> UserListItem-->BaseListItem? Can we not use item.isInteractive
instead here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree they are redundant. I just removed them.
Reviewer Checklist
Screenshots/VideosMacOS: Chrome / Safari43153-web-safari-001.mp4MacOS: Desktop43153-desktop-001.mp4Android: Native43153-android-native-001.mp4Android: mWeb Chrome43153-mweb-chrome-001.mp4iOS: Native43153-ios-native-001.mp4iOS: mWeb Safari43153-mweb-safari-001.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tienifr for the changes. LGTM and tests well too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the delay with reviews. looks good to me 😄
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 9.0.5-3 🚀
|
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
1 similar comment
🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.5-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
This PR is failing because of issue #42552 1720468427627.RPReplay_Final1720462802.mp4 |
🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.5-13 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.6-8 🚀
|
Details
Selecting draft policy while categorizing expense in IOU confirmation page leads to not found page. This PR fixes that.
Fixed Issues
$ #42552
PROPOSAL: #42552 (comment)
Tests
To
field is not pressable and shows normal cursor while hovering overOffline tests
NA
QA Steps
To
field is not pressable and shows normal cursor while hovering overPR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
video_2024-06-06_07-20-27.mp4
Android: mWeb Chrome
video_2024-06-06_07-20-31.mp4
iOS: Native
Screen.Recording.2024-06-06.at.07.16.20-compressed.mov
iOS: mWeb Safari
Screen.Recording.2024-06-06.at.07.18.53-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2024-06-06.at.07.13.16-compressed.mov
MacOS: Desktop
Screen.Recording.2024-06-06.at.07.15.25-compressed.mov